clean up lib

josselinchevalay · Sep 11, 2015 · 261fae1 · 261fae1
1 parent 178e50b
commit 261fae1
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 32 deletions.
diff --git a/lib/Services/BaseService.js b/lib/Services/BaseService.js
@@ -1,3 +1,4 @@
+/* global module*/
 'use strict';
 
 var BaseService = function(containers) {

diff --git a/lib/Services/CapacityService.js b/lib/Services/CapacityService.js
@@ -1,18 +1,19 @@
+/* global require, module*/
 'use strict';
 
-var BaseService     = require('./BaseService.js')
-var Charism         = require('../Capacity/Charism.js')
-var Commerage       = require('../Capacity/Commerage.js')
-var Esquive         = require('../Capacity/Esquive.js')
-var Ragot           = require('../Capacity/Ragot.js')
+var BaseService     = require('./BaseService.js');
+var Charism         = require('../Capacity/Charism.js');
+var Commerage       = require('../Capacity/Commerage.js');
+var Esquive         = require('../Capacity/Esquive.js');
+var Ragot           = require('../Capacity/Ragot.js');
 
 var Service = function() {
     var service = {};
     service.__proto__ = BaseService({
-        "Charism": new Charism(),
-        "Esquive": new Esquive(),
-        "Commerage": new Commerage(),
-        "Ragot": new Ragot()
+        'Charism': new Charism(),
+        'Esquive': new Esquive(),
+        'Commerage': new Commerage(),
+        'Ragot': new Ragot()
     });
 
     return service;

diff --git a/lib/Services/ClassService.js b/lib/Services/ClassService.js
@@ -1,13 +1,14 @@
+/*global require, module*/
 'use strict';
 
 
-var BaseService = require('./BaseService.js')
-var Warrior     = require('../Class/Warrior.js')
+var BaseService = require('./BaseService.js');
+var Warrior     = require('../Class/Warrior.js');
 
 var ClassService = function() {
     var classService = {};
     classService.__proto__ = BaseService({
-        "Warrior": new Warrior()
+        'Warrior': new Warrior()
     });
 
     return classService;

diff --git a/lib/Services/SpellService.js b/lib/Services/SpellService.js
@@ -1,16 +1,17 @@
+/* global require, module */
 'use strict';
 
-var BaseService = require('./BaseService.js')
+var BaseService = require('./BaseService.js');
 
-var FireBall = require('../Spell/FireBall.js')
+var FireBall = require('../Spell/FireBall.js');
 
 var SpellService = function() {
     var spellService = {};
     spellService.__proto__ = BaseService({
-        "FireBall": new FireBall()
+        'FireBall': new FireBall()
     });
 
     return spellService;
-}
+};
 
 module.exports = SpellService;
diff --git a/lib/Spell/BaseSpell.js b/lib/Spell/BaseSpell.js
@@ -1,14 +1,15 @@
+/* global  module */
 'use strict';
 
 
 var BaseSpell = function(){
     var baseSpell = {};
 
-    baseSpell.depend = "";
+    baseSpell.depend = '';
 
-    baseSpell.start = function(caster, target){
+    baseSpell.start = function(){
         /*Implement behavior spell*/
-    }
+    };
 
     return baseSpell;
 };

diff --git a/lib/Spell/FireBall.js b/lib/Spell/FireBall.js
@@ -1,3 +1,4 @@
+/* global require, module */
 'use strict';
 
 var BaseSpell = require('./BaseSpell.js');
@@ -7,17 +8,17 @@ var FireBall = function() {
     var fireBall = {};
     fireBall.__proto__ = BaseSpell();
 
-    fireBall.depend = "IN";
+    fireBall.depend = 'IN';
 
     fireBall.start = function(caster, target, modifier){
-       if(modifier == null){
+       if(modifier === null){
           modifier = utils.MODIFIER.CASUAL;
        }
        var alea = utils.des(100) + modifier;
        if(utils.isSuccess(alea, caster[this.depend])<=0) {
            target.B --;
        }
-    }
+    };
 
 
     return fireBall;

diff --git a/lib/Util/Util.js b/lib/Util/Util.js
@@ -1,10 +1,9 @@
-/* jshint undef : true */
+/* global require, module */
 'use strict';
 /**
 * Util class
 */
-/*global  module, require */
-var _ = require('underscore');
+/*global  module */
 
 var Util = function(){
 
@@ -30,8 +29,8 @@ Util.des = function(number){
 */
 Util.isSuccess = function(value, comparator){
     var diff = 0;
-    if(value == 0 || value == 1)
-      diff = 0 // successfull
+    if(value === 0 || value === 1)
+      diff = 0; // successfull
 
     if(value == 99 || value == 100)
         diff = -999; // epic fail
@@ -48,11 +47,11 @@ Util.isSuccess = function(value, comparator){
 * saut = des(100) + Util.MODIFIER.CASUAL;
 */
 Util.MODIFIER = {
-    "VERY_HARD" : 30,
-    "HARD"      : 20,
-    "CASUAL"    : 0,
-    "EASY"      : -20,
-    "VERY_EASY" : -30,
+    'VERY_HARD' : 30,
+    'HARD'      : 20,
+    'CASUAL'    : 0,
+    'EASY'      : -20,
+    'VERY_EASY' : -30,
 };