Master #1
Open
Master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade frontend-maven-plugin to 1.0 (yeah!) * Upgrade node to v4.4.5 LTS * Upgrade npm to 3.9.2 With these changes, updated the webpack configuration since subpackages are now pulled into the top level.
* Upgrade to React.js 15.3.2 * Upgrade to Spring Boot 1.4.1.RELEASE * Restructure so all the JavaScript is in src/main/js, package.json and webpack.config.js are at the top level of each module * Adjust frontend-maven-plugin so that node is installed in the target folder and subject to clean operations
Patch to resolve "Unresolved directive" error seen on https://spring.io/guides/tutorials/react-and-spring-data-rest/
Windows Command Prompt treats quotes differently when compared to the Unix shell and this causes an error when using cURL to post data or send a header.
This reverts commit e4331fd.
New employee wasn't loaded if the page size wasn't enough to accommodate all the employees. This issue potentially appears in `hypermedia` and `conditional`. If so, fall back to the **self** link.
Catch up to latest versions of core infrastructure. Also polish up certain bits of ES5 code to better use ES6+ options.
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://www.apache.org/licenses/LICENSE-2.0 migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200). # Ignored These URLs were intentionally ignored. * http://maven.apache.org/POM/4.0.0 * http://maven.apache.org/xsd/maven-4.0.0.xsd * http://www.w3.org/2001/XMLSchema-instance
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://www.apache.org/licenses/LICENSE-2.0 with 35 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # HTTP URLs that Could Not Be Fixed These URLs were unable to be fixed. Please review them to see if they can be manually resolved. * [ ] http://es6-features.org/ (200) with 3 occurrences could not be migrated: ([https](https://es6-features.org/) result SSLHandshakeException). * [ ] http://know.cujojs.com/tutorials/promises/consuming-promises (200) with 1 occurrences could not be migrated: ([https](https://know.cujojs.com/tutorials/promises/consuming-promises) result SSLHandshakeException). * [ ] http://stateless.co/hal_specification.html (200) with 2 occurrences could not be migrated: ([https](https://stateless.co/hal_specification.html) result SSLHandshakeException). # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended. * [ ] http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html (ReadTimeoutException) with 2 occurrences migrated to: https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html ([https](https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html) result SSLException). ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * [ ] http://creativecommons.org/licenses/by-nd/3.0/ with 1 occurrences migrated to: https://creativecommons.org/licenses/by-nd/3.0/ ([https](https://creativecommons.org/licenses/by-nd/3.0/) result 200). * [ ] http://curl.haxx.se/ with 1 occurrences migrated to: https://curl.haxx.se/ ([https](https://curl.haxx.se/) result 200). * [ ] http://docs.spring.io/spring-security/site/docs/current/reference/htmlsingle/ with 2 occurrences migrated to: https://docs.spring.io/spring-security/site/docs/current/reference/htmlsingle/ ([https](https://docs.spring.io/spring-security/site/docs/current/reference/htmlsingle/) result 200). * [ ] http://json-schema.org/ with 1 occurrences migrated to: https://json-schema.org/ ([https](https://json-schema.org/) result 200). * [ ] http://json-schema.org/draft-04/schema with 2 occurrences migrated to: https://json-schema.org/draft-04/schema ([https](https://json-schema.org/draft-04/schema) result 200). * [ ] http://roy.gbiv.com/untangled/2008/rest-apis-must-be-hypertext-driven with 1 occurrences migrated to: https://roy.gbiv.com/untangled/2008/rest-apis-must-be-hypertext-driven ([https](https://roy.gbiv.com/untangled/2008/rest-apis-must-be-hypertext-driven) result 200). * [ ] http://stackoverflow.com/a/962040/28214 with 1 occurrences migrated to: https://stackoverflow.com/a/962040/28214 ([https](https://stackoverflow.com/a/962040/28214) result 200). * [ ] http://start.spring.io with 2 occurrences migrated to: https://start.spring.io ([https](https://start.spring.io) result 200). * [ ] http://tools.ietf.org/html/rfc6570 with 5 occurrences migrated to: https://tools.ietf.org/html/rfc6570 ([https](https://tools.ietf.org/html/rfc6570) result 200). * [ ] http://tools.ietf.org/html/rfc7232 with 1 occurrences migrated to: https://tools.ietf.org/html/rfc7232 ([https](https://tools.ietf.org/html/rfc7232) result 200). * [ ] http://www.thymeleaf.org with 5 occurrences migrated to: https://www.thymeleaf.org ([https](https://www.thymeleaf.org) result 200). * [ ] http://docs.spring.io/spring-data/jpa/docs/current/reference/html/ with 2 occurrences migrated to: https://docs.spring.io/spring-data/jpa/docs/current/reference/html/ ([https](https://docs.spring.io/spring-data/jpa/docs/current/reference/html/) result 301). * [ ] http://docs.spring.io/spring-data/rest/docs/current/reference/html/ with 1 occurrences migrated to: https://docs.spring.io/spring-data/rest/docs/current/reference/html/ ([https](https://docs.spring.io/spring-data/rest/docs/current/reference/html/) result 301). * [ ] http://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/ with 1 occurrences migrated to: https://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/ ([https](https://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/) result 301). * [ ] http://facebook.github.io/react/docs/more-about-refs.html with 1 occurrences migrated to: https://facebook.github.io/react/docs/more-about-refs.html ([https](https://facebook.github.io/react/docs/more-about-refs.html) result 301). * [ ] http://facebook.github.io/react/index.html with 1 occurrences migrated to: https://facebook.github.io/react/index.html ([https](https://facebook.github.io/react/index.html) result 301). # Ignored These URLs were intentionally ignored. * http://localhost:8080 with 3 occurrences * http://localhost:8080/api/employees with 3 occurrences * http://localhost:8080/api/employees/1 with 4 occurrences * http://localhost:8080/api/employees/2 with 2 occurrences * http://localhost:8080/api/employees?page=0&size=2 with 3 occurrences * http://localhost:8080/api/employees?page=1&size=2 with 2 occurrences * http://localhost:8080/api/employees?page=2&size=2 with 3 occurrences * http://localhost:8080/api/profile with 1 occurrences * http://localhost:8080/api/profile/employees with 1 occurrences
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://maven.apache.org/xsd/maven-4.0.0.xsd with 6 occurrences migrated to: https://maven.apache.org/xsd/maven-4.0.0.xsd ([https](https://maven.apache.org/xsd/maven-4.0.0.xsd) result 200). # Ignored These URLs were intentionally ignored. * http://maven.apache.org/POM/4.0.0 with 12 occurrences * http://www.w3.org/2001/XMLSchema-instance with 6 occurrences
Fix minor typos and grammar
…in the source. Resolves #109.
I edited all the readme files (and added callouts, as comments, to several code files). I also upgraded the Spring Boot version to 2.2.4 (the latest) and dealt with the resulting breaking changes in org.springframework.hateoas.
Docs: Fix typo on basic/README.adoc
'Why' -> 'why'
Having NodeJS declared in each module makes it quite messy to upgrade. Moving up into the parent POM simplifies and makes it easy to adopt changes for the whole tutorial.
1. git clone https://github.com/spring-guides/tut-react-and-spring-data-rest.git 2. Run any project with spring-boot:run via IntelliJ Idea 3. Open http://localhost:8080/. App works. 4. Run npm run-script watch in the project directory. Watching starts OK. 5. Change app.js and save it. Watch triggers. 6. Open http://localhost:8080/ and hard-refresh the page. Changes from the previous step don't appear. Resolves #112.
Fixed 'Wred' to 'Wired' in line 168.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.