Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution format support resolution #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bancek
Copy link

@bancek bancek commented May 7, 2014

If solution is "html, flash" and supplied contains e.g. flv, the video won't be played because html will be desired and no solution will support flv. This can occur if you use playlist with different formats (mp4, flv, mp3) and not all items in playlist have all formats.

With this fix the first solution that can play format is selected as supported.

@thepag
Copy link
Contributor

thepag commented Nov 20, 2014

This is generic notification that all users issuing pull requests must sign our CLA before we can consider merging with the jPlayer project.

This code goes against the grain of setting a supplied option. However you have got me thinking... The web has evolved a bit and now it is common for a single MP3/MP4 file to work in HTML5 across all browsers, desktop and mobile.

But as jPlayer is designed now, the supplied option is there so jPlayer can optimise the solution and prioritise the formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants