Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readable-stream 3 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use readable-stream 3 #4

wants to merge 1 commit into from

Conversation

realityking
Copy link

This will require a new major release.

@jimmywarting
Copy link

jimmywarting commented Sep 30, 2021

i would have wished it used the builtin node version so you would always get the latest version... otherwise this can lag behind in new features such as not being able to use async iterator... readable-stream is already lagging behind and installs unnecessary dependencies

if you are gona make a breaking release, then also take the opportunity to use class extend instead of using the discuraged inherits fn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants