Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate bucket relay of window #22

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Eliminate bucket relay of window #22

merged 8 commits into from
Mar 1, 2024

Conversation

femshima
Copy link
Member

@femshima femshima commented Jan 17, 2024

TODO: remove thisとなっている部分は,今後LabelとSStreamSetのリファクタリングをする際に消す予定です.

参考までにベンチマークの結果を.

main

test bonsai        ... bench:  17,225,324 ns/iter (+/- 71,784)
test bonsai_letter ... bench:  47,869,986 ns/iter (+/- 102,811)
test is_bonsai     ... bench:  26,584,675 ns/iter (+/- 73,453)

4b8b1e3

test bonsai        ... bench:  16,898,101 ns/iter (+/- 35,576)
test bonsai_letter ... bench:  47,021,735 ns/iter (+/- 240,455)
test is_bonsai     ... bench:  26,094,654 ns/iter (+/- 92,799)

@femshima femshima marked this pull request as draft January 17, 2024 04:25
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (fa9b6ec) to head (70d95d8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   68.78%   68.85%   +0.06%     
==========================================
  Files          26       27       +1     
  Lines        1496     1496              
==========================================
+ Hits         1029     1030       +1     
+ Misses        467      466       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@femshima femshima force-pushed the refactor-bucket-relay branch 2 times, most recently from df681d4 to a668667 Compare January 17, 2024 06:12
@femshima femshima self-assigned this Jan 17, 2024
@femshima femshima marked this pull request as ready for review January 17, 2024 12:20
@femshima femshima requested a review from cm-ayf January 17, 2024 12:31
@femshima femshima marked this pull request as draft January 27, 2024 23:00
@femshima femshima marked this pull request as ready for review January 27, 2024 23:04
@femshima femshima merged commit 9c0cacb into main Mar 1, 2024
6 checks passed
@femshima femshima deleted the refactor-bucket-relay branch March 1, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant