Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serde to parse header #23

Merged
merged 34 commits into from
Mar 1, 2024
Merged

Use serde to parse header #23

merged 34 commits into from
Mar 1, 2024

Conversation

femshima
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: Patch coverage is 82.77311% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 71.32%. Comparing base (9c0cacb) to head (bfe9643).

Files Patch % Lines
src/model/parser/header/de.rs 82.08% 24 Missing ⚠️
src/model/parser/header/deserialize_hashmap.rs 80.55% 7 Missing ⚠️
src/model/parser/mod.rs 86.84% 5 Missing ⚠️
src/model/parser/base.rs 50.00% 2 Missing ⚠️
src/model/parser/header/error.rs 0.00% 2 Missing ⚠️
src/model/parser/header/mod.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   68.85%   71.32%   +2.47%     
==========================================
  Files          27       29       +2     
  Lines        1496     1580      +84     
==========================================
+ Hits         1030     1127      +97     
+ Misses        466      453      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@femshima femshima requested a review from cm-ayf January 29, 2024 12:24
@femshima femshima marked this pull request as ready for review January 29, 2024 12:24
@femshima femshima merged commit 13d1e72 into main Mar 1, 2024
6 checks passed
@femshima femshima deleted the serde branch March 1, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant