Fix --indent 0 implicitly enabling compact-output
#3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it will retain pretty-printing, just remove any indentation.
itchyny
force-pushed
the
fix-indent-zero
branch
3 times, most recently
from
2128ba3 to
954a4ea
Compare
wader
approved these changes
Jan 23, 2025
itchyny
changed the title
--indent 0 implicitly enabling compact-output
|
Thank you. I'll merge next weekend if no one objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2256 and #3202 with modifications.
Fixes #1465 and also fixes #2498.
Closes #2256 and also closes #3202.