Fix date parsing to match docs and support timestamps #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The yup documentation states
The default cast logic of date is pass the value to the Date
constructor, failing that, it will attempt to parse the date as an
ISO date string.
which wasn't true and would manifest for timestamps i.e.
const schema = yup.date();
schema.validateSync(1411500325000) // Failed to validated
as the cast logic would try Date.parse(1411500325000) which would
return an invalid date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yup documentation states
which wasn't true and would manifest for timestamps i.e.
as the cast logic would try Date.parse(1411500325000) which would return an invalid date.