Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance NumberSchema to reject internal whitespace while allowing leading/trailing spaces #2236

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enhance NumberSchema to reject internal whitespace while allowing leading/trailing spaces #2236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/number.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,10 @@ export default class NumberSchema<

let parsed = value;
if (typeof parsed === 'string') {
parsed = parsed.replace(/\s/g, '');
if (parsed === '') return NaN;
// don't use parseFloat to avoid positives on alpha-numeric strings
//Trim leading and trailing whitespace
parsed = parsed.trim();
//Only allow strings that consist of digits, possibly with a single decimal point
if (!/^\d+(\.\d+)?$/.test(parsed)) return NaN;
parsed = +parsed;
}

Expand Down