Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GA4 tracking code #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rohanpsingh
Copy link
Contributor

No description provided.

@aescande
Copy link
Contributor

A very good remark from @gergondet : we need to make sure that we remain GDPR-compliant.
I don't have time to look at that right now, but please check it.
A relevant page might be this.

I'd rather collect a bit less data than having to have a popup for people to select what cookies they accept.

@rohanpsingh
Copy link
Contributor Author

Thanks, I didn't think about this, because we are not using the data with Google Singals/Ads.
There is more information here: https://taginspector.com/articles/google-analytics-4-ga4-compliant-tracking-guide/
I will read it in more details later but it looks like it'll be fine if we implement an appropriate consent pop-up.

@rohanpsingh
Copy link
Contributor Author

rohanpsingh commented Aug 24, 2022

@fkanehiro (@aescande )
I read a bit more about this recently. But there is no definite answer from a reliable source.
In my opinion, it should be totally OK to merge this (given our purpose is only to keep a rough track of number of site visitors).

@aescande
Copy link
Contributor

You should at the very least have something for people to consent. Maybe @gergondet can will some insights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants