Fix static attribute setters

Fixes #199.
jsdom · Apr 29, 2020 · 7d45dfc · 7d45dfc
1 parent 2732dd2
commit 7d45dfc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/lib/constructs/interface.js b/lib/constructs/interface.js
@@ -1350,7 +1350,7 @@ class Interface {
           addOne(`static get ${propName}`, [], body[0]);
         }
         if (body[1] !== undefined) {
-          addOne(`static set ${propName}`, args, body[0]);
+          addOne(`static set ${propName}`, args, body[1]);
         }
       }
     }

diff --git a/test/__snapshots__/test.js.snap b/test/__snapshots__/test.js.snap
@@ -2010,7 +2010,11 @@ exports.install = (globalObject, globalNames) => {
     static set staticAttr(V) {
       const esValue = this !== null && this !== undefined ? this : globalObject;
 
-      return Impl.implementation[\\"staticAttr\\"];
+      V = conversions[\\"DOMString\\"](V, {
+        context: \\"Failed to set the 'staticAttr' property on 'Global': The provided value\\"
+      });
+
+      Impl.implementation[\\"staticAttr\\"] = V;
     }
   }
   Object.defineProperties(Global.prototype, { [Symbol.toStringTag]: { value: \\"Global\\", configurable: true } });
@@ -4727,7 +4731,9 @@ exports.install = (globalObject, globalNames) => {
     static set abc(V) {
       const esValue = this !== null && this !== undefined ? this : globalObject;
 
-      return Impl.implementation[\\"abc\\"];
+      V = conversions[\\"DOMString\\"](V, { context: \\"Failed to set the 'abc' property on 'Static': The provided value\\" });
+
+      Impl.implementation[\\"abc\\"] = V;
     }
   }
   Object.defineProperties(Static.prototype, {
@@ -10821,7 +10827,11 @@ exports.install = (globalObject, globalNames) => {
     static set staticAttr(V) {
       const esValue = this !== null && this !== undefined ? this : globalObject;
 
-      return Impl.implementation[\\"staticAttr\\"];
+      V = conversions[\\"DOMString\\"](V, {
+        context: \\"Failed to set the 'staticAttr' property on 'Global': The provided value\\"
+      });
+
+      Impl.implementation[\\"staticAttr\\"] = V;
     }
   }
   Object.defineProperties(Global.prototype, { [Symbol.toStringTag]: { value: \\"Global\\", configurable: true } });
@@ -13522,7 +13532,9 @@ exports.install = (globalObject, globalNames) => {
     static set abc(V) {
       const esValue = this !== null && this !== undefined ? this : globalObject;
 
-      return Impl.implementation[\\"abc\\"];
+      V = conversions[\\"DOMString\\"](V, { context: \\"Failed to set the 'abc' property on 'Static': The provided value\\" });
+
+      Impl.implementation[\\"abc\\"] = V;
     }
   }
   Object.defineProperties(Static.prototype, {