Implement support for callback interfaces #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
force-pushed
the
feat/constructs/callback-interface
branch
from
2696003
to
48d968f
Compare
2 tasks
domenic
reviewed
Mar 8, 2020
domenic
reviewed
Mar 8, 2020
ExE-Boss
force-pushed
the
feat/constructs/callback-interface
branch
2 times, most recently
from
698c85b
to
9cd8797
Compare
|
I cannot push my fixes to this branch. It would be really nice if you could avoid this separate-organization business and just use personal forks, if you are going to contribute to jsdom. |
|
It says you still haven’t accepted the invite: https://github.com/EB-Forks/jsdom/invitations |
|
The invitation has expired. Regardless, I don't want to have to join another organization to collaborate on my own projects. |
ExE-Boss
changed the title
Co-Authored-By: Domenic Denicola <[email protected]>
ExE-Boss
force-pushed
the
feat/constructs/callback-interface
branch
from
e1e5075
to
422d016
Compare
Co-Authored-By: Timothy Gu <[email protected]>
TimothyGu
reviewed
Apr 1, 2020
README.md
Outdated
|
|
||
| Performs the Web IDL conversion algorithm for this callback interface, converting _value_ into a function that performs [call a user object’s operation](https://heycam.github.io/webidl/#call-a-user-objects-operation) when called, with `thisArg` being the `this` value of the converted function. | ||
|
|
||
| The resulting function has an `objectReference` property, which is the same object as `value` and can be used to perform identity checks, as `convert` returns a new function object every time. |
There was a problem hiding this comment.
Also mention that we don't implement the callback context yet.
There was a problem hiding this comment.
The callback context is used to ensure that the callbacks are executed in the correct realm, which is handled for us by the platform.
|
Thanks! |
TimothyGu
pushed a commit
that referenced
this pull request
Apr 3, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for callback interfaces.
Needed for jsdom/jsdom#2869 (jsdom/jsdom#2884).
To do:
Supersedes and closes #178.
review?(@domenic, @TimothyGu): I’ve now rebased this on top of #182.