Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement “internally create a new object implementing the interface” #239

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

ExE-Boss
Copy link
Contributor

Extracted from #213 because of #213 (comment):

The generated snapshots here seem overcomplicated, and it's not clear why you're modifying existing functionality (like new()).

Blocks:

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after rebase

lib/constructs/interface.js Show resolved Hide resolved
@ExE-Boss ExE-Boss force-pushed the feat/internally-create-new-object branch from eb897a2 to 970cf26 Compare March 20, 2021 21:50
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad about the extra size for such an edge-case feature, but it seems unavoidable, and I appreciate the work you did to make it shorter by using different steps than the spec (with equivalent logic).

@domenic domenic merged commit 3c318aa into jsdom:master Mar 20, 2021
@ExE-Boss ExE-Boss deleted the feat/internally-create-new-object branch March 20, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants