-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merge after #1630] [jsk_robot_startup] Add dryrun option of update_workspace.sh #1817
Open
tkmtnt7000
wants to merge
25
commits into
jsk-ros-pkg:master
Choose a base branch
from
tkmtnt7000:common-update-workspace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Merge after #1630] [jsk_robot_startup] Add dryrun option of update_workspace.sh #1817
tkmtnt7000
wants to merge
25
commits into
jsk-ros-pkg:master
from
tkmtnt7000:common-update-workspace
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in.sh and call it from update_workspace.sh
…to jsk_robot_startup
Co-authored-by: Koki Shinjo <[email protected]>
…ch have bad effects on rostopic pub
tkmtnt7000
force-pushed
the
common-update-workspace
branch
from
June 26, 2023 04:23
abd3b00
to
f22c5c8
Compare
sktometometo
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a master branch version of #1808 and depends on #1630.
Now fetch and pr2 workspaces forcefully update at 3:00, but this function forcibly erases changes in the robot body, which was troublesome when, for example, we wanted to prepare a demonstration the day before a tour.
This PR avoids that situation.
See discussion in #1808.