Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #6 #30 #35

Merged
merged 4 commits into from
Sep 4, 2017
Merged

[Fix] #6 #30 #35

merged 4 commits into from
Sep 4, 2017

Conversation

Kristinita
Copy link

1. Behavior before pull request

I create a new Markdown file → Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Insert Metadata → metadata insert:

Date Metadata

Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Update Article DateDate metadata variable update:

Update Date

2. Behavior after pull request

I add a new metadata variable Modified.

I create a new Markdown file → Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Insert Metadata → metadata with new Modified variable insert, Modified value = Date value:

Modified metadata

Ctrl+Shift+P (⌘⇧p for Mac) → Pelican: Update ModifiedModified variable update, Date variable stay constantly.

Update Modified

3. Argumentation

See @jachin arguments. Date variable — time, when we create article or page. Modified variable — last update time article or page. We must update Modified, not Date. See File Metadata section in official documentation.

4. Testing environment

Operating system and version:
Windows 10 Enterprise LTSB 64-bit EN
Sublime Text:
Build 3126
Syntax:
Markdown

5. Notes

  1. I'm sorry, I don't know reStructuredText — I don't know, how my changes will work in rst files.
  2. This pull request don't solve [Feature request] Modified setting update on save #30 issue. Modified variable doesn't update by save.

Thanks.

@Kristinita
Copy link
Author

@jsliang , I fix #30 in new commit.

Thanks.

@Kristinita
Copy link
Author

@jsliang , ping.

Thanks.

@jsliang
Copy link
Owner

jsliang commented Sep 4, 2017

Hi @Kristinita ,

Thank you for your PR and sorry for the late reply! Haven't been logged in to github for quite a while.

Jenny

@jsliang jsliang merged commit e25dd03 into jsliang:st3 Sep 4, 2017
@Kristinita
Copy link
Author

Type: Update request 📈

@jsliang, what about merging st3 branch (with my pull request) to the master branch? Sublime Text 2 hasn’t been updated since 2013; in 2021, Sublime Text 4 appeared. I think it’s time to drop support for Sublime Text 2 or at least make the version for Sublime Text 3 as main branch.

Plugin version from st3 branch still works for me in Sublime Text 4 Build 4169.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants