Proposed fix for issue 590 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset keyRedaction variable so that the parent's keyRedaction will not be carried onto its children which used to cause the key to be an empty array inside the ngModel builder.
|
Thanks @elbunuelo, I have a test in PR 652 that currently fails due to this issue (#590). So this PR should make my test pass! |
|
@joelwkent I'm glad to read it! Now I just have to work out why aren't the tests passing |
|
@elbunuelo there are some tests failing because of styles not being set, I think David said those tests should be moved to the decorators instead anyway, but I havent had a chance to fix it yet. Nice PR, glad to see the template properly filled in, I will fix it's styling today, nice PR :) |
|
@joelwkent did you get a chance to see if this resolved your test issue? |
|
Yes, happy to confirm this PR fixes the issue in the test I have added in the arrayIndices PR. |
pgrm
added a commit
to hetras/angular-schema-form
that referenced
this pull request
Jan 10, 2017
ymarcon
pushed a commit
to obiba/angular-schema-form
that referenced
this pull request
Nov 13, 2022
ymarcon
added a commit
to obiba/angular-schema-form
that referenced
this pull request
Nov 13, 2022
ymarcon
pushed a commit
to obiba/angular-schema-form
that referenced
this pull request
Nov 14, 2022
ymarcon
added a commit
to obiba/angular-schema-form
that referenced
this pull request
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue 590, which describes a bug that appears when you're using nested arrays.
The described bug causes element values in the second nesting level to appear as [Object object].
Fixes Related issues
json-schema-form/angular-schema-form-bootstrap#9
Checklist
@json-schema-form/angular-schema-form-lead
Reset keyRedaction variable so that the parent's keyRedaction will not be carried onto its children which used to cause the key to be an empty array inside the ngModel builder.