Added support for List Parts #119
Conversation
|
Hey @felixhageloh @jubos what's the status on this? Would really like to see this merged in! 😃 |
As described here http://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadListParts.html Cleaned up related code a bit as well.
|
What's the status of this PR? |
|
Hey guys, I can merge this, let me check with jubos first though. |
|
Thank you, @pickhardt! We're using this code in our project for a year already. It'll be very nice if we can switch from our fork to original repo ❤️ |
|
Hey @jubos! Can we have a few minutes of your time to review this PR, please 🙏 ? |
| etag = Digest::MD5.hexdigest(chunk) | ||
|
|
||
| raise new Error "invalid file chunk" unless part[:etag] == etag | ||
| fail StandardError, "invalid part #{part[:etag]}" unless part[:etag] == etag |
There was a problem hiding this comment.
Why did you switch this to fail?
There was a problem hiding this comment.
following the rule of thumb of only using raise in rescue blocks (in other words: because my linter told me so)
There was a problem hiding this comment.
There was a problem hiding this comment.
forgot to mention: I can change that to raise if that's more in line with you codebase
|
Any updates on this PR? |
|
Hi, This issue is blocking us, so unfortunately we have to fork away until this is solved. Thanks! |
* Add ability to filter objects and batch delete * Skip broken/corrupt files on intial load
As described here
http://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadListParts.html
This only adds rudimentary features for List Parts. Things like pagination and Owner/Initiator are not supported.
Cleaned up related code (
combine_object_parts) a bit as well. Git blame doesn't show it but it was mostly my code originally :)