Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test deploy test deploy revision aws to gating #163

Conversation

hmlanigan
Copy link
Member

@hmlanigan hmlanigan commented Nov 15, 2023

Move a long passing test from proving grounds to gating.

Update docs based on confusion trying to re-generate the jobs due to forgetting the make target and #156.

Fix bug in make install-deps target so the GitHub actions can run. See commit for details.

Include the cli arg introduced in PR 156 to ensure we use the 3.3 branch
to generate the test files. Also to remind us of the make target which
handles everything for you.
in all saved results. Move from proving ground to gating.
Found workaround for "AttributeError: cython_sources" failure here:
yaml/pyyaml#601

Follow up from being able to run the static-analysis make target
against is additional tests added to the deadcode list.

Some formating changed when I ran shfmt on the lint script file.
@hmlanigan hmlanigan force-pushed the move-test-deploy-test-deploy-revision-aws-to-gating branch from 2a5c1fc to 3352855 Compare November 17, 2023 14:48
@hmlanigan
Copy link
Member Author

/merge

@hmlanigan hmlanigan merged commit 0b6a360 into juju:main Nov 17, 2023
@hmlanigan hmlanigan deleted the move-test-deploy-test-deploy-revision-aws-to-gating branch November 17, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants