Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure obsolete tests are not run on 4.0 #209

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

wallyworld
Copy link
Member

@wallyworld wallyworld commented Nov 25, 2024

Juju 4.0 is failing ci test runs on jenkins because said functionality is not supported in 4.0. We need a way to mask out such tests. In some cases, the 4.0 branch just leaves stubs behind, so the tests pass, in other cases, the tests have already been deleted so fail. The stubbed out tests in 4.0 were incorrectly not generated any more for 3.6.

This branch changes how the test suite metadata is composed - it now queries githib directly. This is done for the "main" and "3.6" branches, thereby allowing tests which no longer exist in 4.0 to be identified. The conditional regexp applied to each test job is adjusted to allow for tests to be excluded from a certain version onwards if they are marked as removed. The tool config also supports manually specify test removal; this is used where tests have not been deleted from the main branch yet, or to account for individual tests within a suite that have been removed.

There's a bit of churn in the existing conditional yaml to keep the template manageable for the different conditions.

When specifying whole suites in "removed" or "introduced" sections, there's no need for "-*" as it can be implied from the suite name.

Since the github queries can take a minute or so, a progress bar is added.

Note also that some tests from 3.6 were incorrectly removed from jenkins - branches and metrics. This PR allows those to be added back in.

JIRA card: JIRA_7126

Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm happy with this.

@wallyworld wallyworld force-pushed the fix-testsuite-versioning branch 3 times, most recently from 82c95a2 to 494bfa6 Compare November 25, 2024 08:45
Add support for masking out tests from 3.x that are not applicable to 4.0.
@wallyworld wallyworld force-pushed the fix-testsuite-versioning branch from 494bfa6 to d02fb25 Compare November 25, 2024 09:13
@wallyworld wallyworld merged commit cc154f6 into juju:main Nov 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants