Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable failing integration test #1119

Closed

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Oct 1, 2024

Description

This test uses the ghost charm:

https://charmhub.io/ghost?channel=latest/edge
https://charmhub.io/ghost

Which has not been updated since 2020 and only supports 16.04 and 14.04 bases.

I think that requires Juju 2.8, doesn't it?

I'll open a separate ticket to update the test.

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 1, 2024

Part of #1108

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 1, 2024

The set of integrations tests that fail is smaller with this PR:

XFAIL tests/integration/test_model.py::test_deploy_bundle_with_overlay_as_argument - The `ghost` charm is hopelessly out of date
FAILED tests/integration/test_application.py::test_action - juju.errors.JujuA...
FAILED tests/integration/test_charmhub.py::test_subordinate_false_field_exists
FAILED tests/integration/test_model.py::test_deploy_bundle_with_multiple_overlays_with_include_files
FAILED tests/integration/test_model.py::test_attach_resource - asyncio.except...
FAILED tests/integration/test_application.py::test_app_relation_destroy_block_until_done

@james-garner-canonical
Copy link
Contributor

This test fails 100% of the time when running integration tests on main 20 times. I'm definitely in favour of disabling it.

Do you prefer xfail to skip here? skip is what's been used for many other tests in this repo, and has the advantage(?) of at least making the integration tests run faster.

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 7, 2024

Closing in favour of more comprehensive set.

@dimaqq dimaqq closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants