ci: run setup-python before actions-operator to fix tox install #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github's rollout of 24.04 for ubuntu-latest has now reached python-libjuju, so `pip install tox` no longer works -- 24.04 prevents installing packages using pip. This causes an error with in 'Setup operator environment' using charmed-kubernetes/actions-operator@main. The fix is to run our 'Setup Python' step using actions/setup-python before actions-operator instead of after. Since this takes care of installing tox, we can remove pip install tox for the jobs using these steps. Also bump setup-python to v5 for integration-quarantine, matching the recent PR bumping the version for other jobs.
james-garner-canonical
force-pushed
the
24.10/ci/fix-24-04-tox
branch
from
f5f74c1
to
2679d84
Compare
dimaqq
approved these changes
Oct 9, 2024
|
/merge |
|
I don't think we noticed the significance of this at the time, but we got our first green CI tick here -- the quarantined integration tests suddenly pass! It's unexpected but makes sense that they could be affected here, since this is a version bump for their actions afterall. |
|
But the first commit also passes with a green tick, and that's the one where I forgot to bump the versions ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Github's rollout of
24.04forubuntu-latesthas now reachedpython-libjuju, sopip install toxno longer works --24.04prevents installing packages usingpip. This causes an error in 'Setup operator environment' usingcharmed-kubernetes/actions-operator@main. The fix is to run our 'Setup Python' step usingactions/setup-pythonbeforeactions-operatorinstead of after.Since this takes care of installing
tox, we can removepip install toxfor the jobs using these steps.Also bump
setup-pythontov5for integration-quarantine, matching the recent PR bumping the version for other jobs.QA Steps
Tests no longer fail when trying to install
tox, as they started doing in the last 12 hours.Notes
Fix documented in charmed-kubernetes/actions-operator here.