-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use fail-fast, not continue-on-error #1167
Conversation
891f517
to
b2823db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The postgres charm should have an assumes block in the metadata yaml, which should state that it doesn't work for less than 3.3.0.
It probably does. The point of this PR is that it doesn't make sense to run a test that uses secrets facade v2 or deploys postgresql against older Juju versions, these tests will always fail. |
Here's the error that is encountered against Juju 3.1:
|
b2823db
to
79ad99c
Compare
Limiting this PR to only fixing the CI, without any code changes. |
/merge |
Looks like I was wrong in #1163
Using https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast instead.
Skip tests that are guaranteed to fail against older Juju controllers.