Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use fail-fast, not continue-on-error #1167

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Oct 17, 2024

Looks like I was wrong in #1163
Using https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast instead.
Skip tests that are guaranteed to fail against older Juju controllers.

Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The postgres charm should have an assumes block in the metadata yaml, which should state that it doesn't work for less than 3.3.0.

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 21, 2024

It probably does.
I don't have the error snippet ready, but the error suggested that several charm revisions were considered, but there was no charm revision that could be run.
I've opened #1173 with a single skip disabled to catch the actual detailed error.

The point of this PR is that it doesn't make sense to run a test that uses secrets facade v2 or deploys postgresql against older Juju versions, these tests will always fail.

@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 22, 2024

Here's the error that is encountered against Juju 3.1:

Charm feature requirements cannot be met:
  - charm requires at least one of the following:
    - charm requires all of the following:
      - charm requires feature "juju" (version < 3.0.0) but model currently supports version 3.1.10
    - charm requires all of the following:
      - charm requires feature "juju" (version >= 3.4.3) but model currently supports version 3.1.10
    - charm requires all of the following:
      - charm requires feature "juju" (version >= 3.5.1) but model currently supports version 3.1.10

Feature descriptions:
  - "juju": the version of Juju used by the model

For additional information please see: https://juju.is/docs/olm/supported-features

@dimaqq dimaqq marked this pull request as draft October 24, 2024 03:21
@dimaqq dimaqq marked this pull request as ready for review October 30, 2024 10:27
@dimaqq
Copy link
Contributor Author

dimaqq commented Oct 30, 2024

Limiting this PR to only fixing the CI, without any code changes.

@james-garner-canonical
Copy link
Contributor

/merge

@jujubot jujubot merged commit 94e12e7 into juju:main Oct 30, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants