Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pytest.ini to register custom pytest marks #912

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Add pytest.ini to register custom pytest marks #912

merged 1 commit into from
Jul 19, 2023

Conversation

cderici
Copy link
Contributor

@cderici cderici commented Jul 16, 2023

Description

Add a .pytest.ini at the top level to register custom pytest marks to prevent pytest from emitting warnings for each mark, such as:

tests/unit/test_model.py:371: 24 warnings
  /home/caner/work/python-libjuju/tests/unit/test_model.py:371: PytestUnknownMarkWarning: Unknown pytest.mark.wait_for_idle - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    @pytest.mark.wait_for_idle

QA Steps

No QA needed.

Needs to be forward-ported to the main branch. Proactively added the bundle mark as it's used in there.

@cderici cderici added hint/2.9 going on 2.9 branch area/forward-port to be forward ported - remove label after port labels Jul 16, 2023
@cderici cderici added this to the 2.9.44 milestone Jul 16, 2023
@cderici
Copy link
Contributor Author

cderici commented Jul 19, 2023

/merge

@jujubot jujubot merged commit b79d066 into juju:2.9 Jul 19, 2023
9 checks passed
@cderici cderici mentioned this pull request Jul 20, 2023
Merged
jujubot added a commit that referenced this pull request Jul 20, 2023
@jujubot
Merge pull request #919 from cderici/release-2.9.44.0
a07e224 
#919

## What's Changed
* [JUJU-4110] `charm_name` on Application object by @cderici in #901
* [JUJU-4204] Model.name on 2.9 by @cderici in #902
* [JUJU-4231] wait_for_idle to consider app status by @cderici in #905
* Stabilize sphinx doc builds for `2.9` track by @cderici in #911
* Add pytest.ini to register custom pytest marks by @cderici in #912
* [JUJU-4291] Removing Upper Constraint by @markbeierl in #916

[JUJU-4110]: https://warthogs.atlassian.net/browse/JUJU-4110?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4204]: https://warthogs.atlassian.net/browse/JUJU-4204?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4231]: https://warthogs.atlassian.net/browse/JUJU-4231?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4291]: https://warthogs.atlassian.net/browse/JUJU-4291?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-w-shaw jack-w-shaw jack-w-shaw approved these changes

Assignees
No one assigned
Labels
area/forward-port to be forward ported - remove label after port hint/2.9 going on 2.9 branch
Projects
None yet
Milestone
2.9.44
Development

Successfully merging this pull request may close these issues.
3 participants
@cderici @jack-w-shaw @jujubot