New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data source juju_application #630

Open

shipperizer wants to merge 4 commits into juju:main from shipperizer:ds/application

shipperizer commented Nov 15, 2024 •

edited

Loading

Description

Creation of a juju_application data source

Type of change

Add new resource

Environment

Juju controller version: 3.5+
Terraform version: 1.8.2+

QA steps

Manual QA steps should be done to test this PR.

terraform {
  required_providers {
    juju = {
      source  = "juju/juju"
      version = "> 0.14.0"
    }
  }

  required_version = ">= 1.5.0"
}

variable "revision" {
  type = string
}
########################

resource "juju_application" "hydra" {
  model = "test"
  trust = true

  charm {
    name    = "hydra"
    channel = "latest/edge"
    base    = "[email protected]"
    revision = var.revision
  }
}


### HYDRA dependent ###
data "juju_application" "hydra" {
  model = juju_application.hydra.model
  name  = juju_application.hydra.name
}

Contributor

jujubot commented Nov 15, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

1 similar comment

Contributor

jujubot commented Nov 15, 2024

Thanks for opening a pull request! Please follow the instructions here to ensure your pull request is ready for review. Then, a maintainer will review your patch.

@hpidcock @anvial

shipperizer marked this pull request as draft

November 15, 2024 11:55

shipperizer force-pushed the ds/application branch 3 times, most recently from 61af9f7 to cba4340 Compare

November 15, 2024 15:33

shipperizer marked this pull request as ready for review

November 15, 2024 15:37

shipperizer changed the title ~~Ds/application~~ Data source juju_application

hmlanigan added the state/codefreeze label

hmlanigan requested review from hmlanigan and alesstimec

November 15, 2024 15:58

shipperizer force-pushed the ds/application branch from cba4340 to d838393 Compare

November 18, 2024 10:30

alesstimec reviewed

View reviewed changes

internal/provider/data_source_application.go Show resolved Hide resolved

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

docs/data-sources/application.md Outdated Show resolved Hide resolved

shipperizer force-pushed the ds/application branch 2 times, most recently from ed4b00c to a979d62 Compare

November 18, 2024 13:10

pik4ez-canonical approved these changes

View reviewed changes

pik4ez-canonical left a comment

A couple minor comments/documentation adjustments requested. Otherwise LGTM.

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

docs/data-sources/application.md

pik4ez-canonical Nov 18, 2024

I believe docs/index.md also needs to be adjusted to include the application data source.

shipperizer force-pushed the ds/application branch from a979d62 to 9c24683 Compare

November 18, 2024 15:52

pik4ez-canonical approved these changes

View reviewed changes

hmlanigan reviewed

View reviewed changes

Member

hmlanigan left a comment

I'm confused about to why this is new data source is useful if it no longer contains the trust and units value?

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

internal/provider/data_source_application_test.go Outdated Show resolved Hide resolved

internal/provider/provider.go Outdated Show resolved Hide resolved

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

internal/provider/data_source_application.go Outdated Show resolved Hide resolved

internal/provider/helpers.go Outdated Show resolved Hide resolved

shipperizer force-pushed the ds/application branch from 9c24683 to 1a5985c Compare

November 22, 2024 09:23

alesstimec removed the state/codefreeze label

shipperizer force-pushed the ds/application branch from 1a5985c to 20a5e8d Compare

December 10, 2024 07:46

shipperizer added 4 commits

December 10, 2024 10:52


          feat: introduce juju_application data source

d5171b7


          feat: hook up new resource to the provider

5d9dda3


          docs: juju application data source

7bcea89


          docs: adjust index.md

b254b6a

shipperizer force-pushed the ds/application branch from 20a5e8d to b254b6a Compare

December 10, 2024 10:53

alesstimec approved these changes

View reviewed changes

internal/provider/data_source_application.go

+              		Description: "A data source that represents a single Juju application deployment from a charm.",
+              		Attributes: map[string]schema.Attribute{
+              			"name": schema.StringAttribute{
+              				Description: "Name of the application deployment.",

Member

alesstimec Dec 20, 2024

nitpick: "Name of the application."

internal/provider/data_source_application.go

+              		return
+              	}
+              	//SubsystemTrace(subCtx, "datasource-model", "hello, world", map[string]interface{}{"foo": 123})

Member

alesstimec Dec 20, 2024

remove commented out lines

alesstimec requested review from hmlanigan and pik4ez-canonical

December 20, 2024 10:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet