WIP: fix for secret_id of the juju_secret_resource #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kian Parvin <[email protected]>
The `secret_id` field of the `juju_secret_resource` should hold the secret URI instead of the ID so that other resources can use it without having to manually prefix it with `secret:`.
alesstimec
changed the title
alesstimec
requested review from
hmlanigan,
anvial and
kian99
and removed request for
hmlanigan
hmlanigan
reviewed
Dec 18, 2024
There was a problem hiding this comment.
This change will break existing configurations using the secret data source or resource. Are we sure that's what we want?
The integration tests are missing a test: TestAcc_ResourceSecret_UpgradeProvider.
It is possible to solve the issue without breaking anything by updating the value before sending to juju where necessary.
todo: finish filling in the PR description.
todo: rebase with only the relevant commit rather than combining unrelated PRs.
todo: update commit message with details for a breaking change if that is the decision:
w.g. BREAKING CHANGE: extends key in config file is now used for extending other config files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
secret_idfield of thejuju_secret_resourceshould hold the secret URI instead of the IDso that other resources can use it without having to manually prefix it with
secret:.Fixes: #644
Type of change
Environment
Juju controller version:
Terraform version:
QA steps
Manual QA steps should be done to test this PR.
Additional notes
<Please add relevant notes & information, links to mattermost chats, other related issues/PRs, anything to help understand and QA the PR.>