-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final coxeter orbits code and runtime analysis from Jonas, Lovis and Robert, Raoul #46
Open
LovisAnderson
wants to merge
19
commits into
julian-upc:master
Choose a base branch
from
LovisAnderson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orbit is interative....
… with Lovis and renamed folder Jonas to JonasLovis
MergeMerge
due to use of set and not vector for new points
new Points is a list again
Improved speed
- deleted matrix in mirror() - A,B,D,E,F,H,I works - timer in orbit() is better
- changed back to only calculate scalar once.
Programm faster
Did you include the results on timings and orbit sizes? I couldn't seem to find them... |
Actually, your code is incomplete because it doesn't take rounding errors into account. Modifying
yields an incorrect orbit size of 140 (should be 120). Handling these rounding issues is actually one of the main points of this exercise... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.