Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final coxeter orbits code and runtime analysis from Jonas, Lovis and Robert, Raoul #46

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

LovisAnderson
Copy link
Contributor

No description provided.

@julian-upc
Copy link
Owner

Did you include the results on timings and orbit sizes? I couldn't seem to find them...

@julian-upc
Copy link
Owner

Actually, your code is incomplete because it doesn't take rounding errors into account. Modifying main.cpp to

const static char letter = 'H';

int main(int argc, const char * argv[]) {
    for (int i = 3; i < 4; i++){
      VectorType vec {0.0000001, 4.3, 1.2};
      GeneratorList list = simple_roots(letter, i);
...

yields an incorrect orbit size of 140 (should be 120).

Handling these rounding issues is actually one of the main points of this exercise...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants