Merge pull request #16 from julianrubisch/rails-7-1-support

Rails 7 1 support

.github/workflows/tests.yml

@@ -14,8 +14,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
        matrix:
-         ruby-version: [2.7.2, 3.0.3, 3.1.0]
-         rails-version: ['6_0', '6_1', '7_0'] 
+         ruby-version: [3.1.4, 3.2.3, 3.3.0]
+         rails-version: ['6_0', '6_1', '7_0', '7_1']
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails-version }}.gemfile         
     steps:

app/channels/cubism/presence_channel.rb

@@ -21,10 +21,14 @@ def unsubscribed
 
   def appear
     resource.set_present_users_for_scope(resource.present_users_for_scope(scope).add(user.id), scope) if scope
+  rescue ActiveRecord::RecordNotFound
+    # do nothing if the user wasn't found
   end
 
   def disappear
     resource.set_present_users_for_scope(resource.present_users_for_scope(scope).delete(user.id), scope) if scope
+  rescue ActiveRecord::RecordNotFound
+    # do nothing if the user wasn't found
   end
 
   private

gemfiles/rails_7_1.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pry", group: [:development, :test]
+gem "rails", "7.1.3.2"
+gem "sqlite3", "~> 1.4"
+
+gemspec path: "../"

lib/cubism/preprocessor.rb

@@ -14,6 +14,7 @@ def process
       begin
         do_parse
       rescue NameError
+        # TODO we need a better way to handle this, leads to false negatives
         # we ignore any name errors from unset instance variables or local assigns here
       end
 
@@ -23,11 +24,21 @@ def process
     private
 
     def do_parse
-      ActionView::Template::Handlers::ERB::Erubi.new(@source).evaluate(@view_context)
+      erubi = ActionView::Template::Handlers::ERB::Erubi.new(@source)
+
+      evaluate_view(erubi, @view_context)
     rescue SyntaxError
       end_at_end = /(<%\s+end\s+%>)\z/.match(@source)
       @source = end_at_end ? @source[..-(end_at_end[0].length + 1)] : @source[..-2]
       do_parse
     end
+
+    def evaluate_view(erubi, view_context)
+      view = Class.new(ActionView::Base) {
+        include view_context._routes.url_helpers
+        class_eval("define_method(:_template) { |local_assigns, output_buffer| #{erubi.src} }", erubi.filename.nil? ? "(erubi)" : erubi.filename, 0)
+      }.empty
+      view._run(:_template, nil, {}, ActionView::OutputBuffer.new)
+    end
   end
 end

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@minthesize/cubism",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Lightweight Resource-Based Presence Solution with CableReady.",
   "main": "./dist/cubism.umd.min.js",
   "module": "./dist/cubism.min.js",