-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FloorPlan gradle plugin #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`minimize()` removes unused code, but graphviz-java dependency bundles in the native (C) dependency that is accesses via reflection (System.loadLibrary) and thus was getting removed.
julioz
force-pushed
the
gradle-plugin-mvn-local
branch
from
June 4, 2020 13:04
7538d53
to
6f6d1b3
Compare
julioz
force-pushed
the
gradle-plugin-mvn-local
branch
from
June 4, 2020 18:04
6e50423
to
d87d1c9
Compare
julioz
force-pushed
the
gradle-plugin-mvn-local
branch
from
June 4, 2020 19:06
e327b71
to
ec565c9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Gradle Plugin implementation, with initial integration tests, sample project for manual end to end test and updates documentation.
Nice to haves (follow-ups):
<input_dir>/com.mypackage.mydatabase/1.json
should end up as<output_dir>/com.mypackage.mydatabase/1.dbml
Provider
API (Use the Provider API for the Gradle Plugin properties #32)DirectoryProperty
and then to pass it, use something likeproject.layout.projectDirectory.dir("schemas")
, so that the actual file will be resolved when the task runsclosure.property = value
in consumer's build.gradle, instead of forcing a full block likesvg { enabled = true }
(Gradle Plugin: Allow for one-line direct property definition #34)