Add capability to make resource outputs nullable during diff phase #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to fix the Build and Release badges
Previously the FQDN was set as hostname. This is not valid since the hostname should be only the part before the first dot. This becomes visible when starting a consul container which will then warn that it cannot use the hostname as node_name because it contains invalid characters.
Docker does not support non-recursive binds with the src:target:options format and does not support selinux relabeling with type=bind,src=/src,target=/target,options. So we need to error out if both are requested :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Diff phase of Jumppad does not execute the providers; it only parses the config and looks for differences in the HCL composition of the resources. Because of this, any interpolated values the provider sets will fail to resolve.
This PR updates the version of HCLConfig that can report missing interpolation values as a warning, not an error. This enables us to distinguish between an actual error, such as an invalid config, and missing interpolation.
Note: the
applyphase treats missing interpolation warnings as errors, which is the same behavior as before.