Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when setting annotation is missing. #135

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Fix NPE when setting annotation is missing. #135

merged 3 commits into from
Jan 8, 2025

Conversation

junghoon-vans
Copy link
Owner

@junghoon-vans junghoon-vans commented Jan 2, 2025 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our issue tracker. Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #134

@junghoon-vans junghoon-vans self-assigned this Jan 2, 2025
@junghoon-vans junghoon-vans added type: bug A general bug in: core Issues in core support labels Jan 2, 2025
@junghoon-vans junghoon-vans changed the title Add null handling for pagination param in setting annotation. An error occurs if an entity is declared without a setting annotation. Jan 2, 2025
@junghoon-vans junghoon-vans force-pushed the fix-error-occurs-if-an-entity-is-declared-without-a-setting-annotation branch 2 times, most recently from 89bbda9 to 326c050 Compare January 8, 2025 14:35
@junghoon-vans junghoon-vans force-pushed the fix-error-occurs-if-an-entity-is-declared-without-a-setting-annotation branch from 326c050 to 69018ae Compare January 8, 2025 15:15
@junghoon-vans junghoon-vans changed the title An error occurs if an entity is declared without a setting annotation. Fix NPE when setting annotation is missing. Jan 8, 2025
@junghoon-vans junghoon-vans merged commit f448a45 into main Jan 8, 2025
1 check passed
@junghoon-vans junghoon-vans deleted the fix-error-occurs-if-an-entity-is-declared-without-a-setting-annotation branch January 8, 2025 15:23
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@junghoon-vans junghoon-vans

Labels
in: core Issues in core support type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error occurs if an entity is declared without a setting annotation.
1 participant
@junghoon-vans