Provide mechanism for managing resources across engines and executions #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816
YongGoose
changed the title
This is a prerequisite for junit-team#4250.
`Class.forName()` from `java.base/java.lang` has already built-in support for type names matching: - _Primitive arrays such as "[I", "[[[[D", etc._ and - _Object arrays such as "[Ljava.lang.String;", etc._ This commit deletes the redundant implementation from JUnit's internal `ReflectionUtils` helper.
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
marcphilipp
reviewed
Jan 23, 2025
| @@ -127,4 +129,5 @@ public interface Launcher { | |||
| @API(status = STABLE, since = "1.4") | |||
| void execute(TestPlan testPlan, TestExecutionListener... listeners); | |||
|
|
|||
| NamespacedHierarchicalStore<Namespace> getStore(LauncherDiscoveryRequest launcherDiscoveryRequest); | |||
There was a problem hiding this comment.
What's the use case for this method? Test engines don't have access to the Launcher so we'll need to pass this store as part of LauncherDiscoveryRequest and ExecutionRequest, don't we?
There was a problem hiding this comment.
I think I need to study a bit more.
I’ll make revisions and add comments by the end of the weekend!
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit 7b4b972.
…4266) Prior to this commit, a `DisplayNameGenerator` could access the type of a `@Nested` test class as well as the enclosing class in which a `@Nested` test class is declared, but it could not access the concrete runtime type of the enclosing instance for a `@Nested` test class. When a `DisplayNameGenerator` is used to build hierarchical display names, this could lead to confusing results or even conflicting results depending on the structure of the test classes used, "conflicting" in the sense that two nested test classes may have identical display names that do not represent the runtime structure of the test classes. Now, each `DisplayNameGenerator` receives the list of enclosing instance types when computing the display name of a nested test class or test method. Resolves junit-team#4130. --------- Co-authored-by: Sam Brannen <[email protected]>
Make API consistent with `DisplayNameGenerator` prior to releasing it in 5.12. Resolves junit-team#4163. --------- Co-authored-by: Sam Brannen <[email protected]>
…team#4274) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…it-team#4279) The `@TempDir` annotation on a constructor parameter is copied to the generated `final` instance field. This caused it top be picked up by `TempDirectory` for instance field injection which then failed because the field was `final`. This change now checks if a test class is an instance of a record type and skips instance field injection. Since records cannot have any instance fields besides the ones generated from their constructor, there's no need to inject values into any of them.
Issue: junit-team#2816
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816 Signed-off-by: yongjunhong <[email protected]>
Issue: junit-team#2816
Issue: junit-team#2816
# Conflicts: # junit-platform-engine/src/main/java/org/junit/platform/engine/ExecutionRequest.java
This reverts commit 4de6db8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2816
Overview
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations