Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide runtime enclosing instance types to ResourceLocksProviders #4267

Merged

Conversation

marcphilipp
Copy link
Member

Resolves #4163.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this one is similar to #4266, I did not review this one as thoroughly.

Though, I did make a few suggestions for minor polishing.

The implementation looks pretty solid (and again, similar to #4266). Plus the tests look good.

So, I'll leave it up to your judgment for whether it's "good to go".

@marcphilipp marcphilipp requested a review from sbrannen January 25, 2025 17:44
@marcphilipp marcphilipp force-pushed the marc/4163-resource-locks-provider-runtime-enclosing-types branch from b2b5d42 to c1fc7d1 Compare January 26, 2025 09:54
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the previous changes!

I've requested two minor Javadoc changes.

@marcphilipp marcphilipp force-pushed the marc/4163-resource-locks-provider-runtime-enclosing-types branch from 467c641 to 4846127 Compare January 26, 2025 18:09
@marcphilipp marcphilipp merged commit 511ab7d into main Jan 26, 2025
15 checks passed
@marcphilipp marcphilipp deleted the marc/4163-resource-locks-provider-runtime-enclosing-types branch January 26, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ResourceLockProvider's methods to be in sync with DisplayNameGenerator
2 participants