feat: adds oneagent initialization to django start #5
+72
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abxsantos
requested review from
spy7,
ricardochaves,
niltonfrederico,
MatheusGeiger,
lgigek,
eduard0m0ya and
a team
MatheusGeiger
approved these changes
Mar 28, 2024
ricardochaves
approved these changes
Apr 5, 2024
| build-backend = "poetry.core.masonry.api" | ||
|
|
||
| [tool.poetry] | ||
| name = "autodynatrace" |
There was a problem hiding this comment.
[question]
Shouldn't this project be named jsm-autodynatrace?
| Homepage = "https://github.com/juntossomosmais/OneAgent-SDK-Python-AutoInstrumentation" | ||
| "Issue Tracker" = "https://github.com/juntossomosmais/OneAgent-SDK-Python-AutoInstrumentation/issues" | ||
|
|
||
|
|
Comment on lines
+21
to
+24
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.4", | ||
| "Programming Language :: Python :: 3.5", | ||
| "Programming Language :: Python :: 3.6", |
There was a problem hiding this comment.
[suggestion]
Add remaining versions, or keep only Python :: 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
This adjusts the service data not being sent to dynatrace correctly (trace_id, span_id, etc.) in a django application running with gunicorn.
There were some issues that helped finding out how we could solve this:
Dynatrace/OneAgent-SDK-for-Python#9 (comment)
dynatrace-oss#73 (comment)
Then the documentation itself
https://github.com/Dynatrace/OneAgent-SDK-for-Python?tab=readme-ov-file#using-the-oneagent-sdk-for-python-with-forked-child-processes-only-available-on-linux
The implementation proposed here, aims to force the child processes of gunicorn to be instrumented at the app ready stage, thus allowing the correct data to be sent to one agent.
To better observe this, I've added a new view allowing the service to call itself.
Evidences
Traces being displayed
Specific distributed trace of a ping GET request.
Logs being displayed
