Skip to content

Commit

Permalink
docs(Carousel): add caveat about inject styles
Browse files Browse the repository at this point in the history
  • Loading branch information
schirrel committed Aug 9, 2023
1 parent 8a236a6 commit 0287647
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,6 @@ The [Swiper](https://swiperjs.com/) was the only option considered.
## Decision
We have decided to use Swiper as our Carousel component library, once it match our requirements and we have a previous knowledge, doing a internal wrapper to maintain the Atomium signature.


## Caveats
An important point to keep in mind is the need of use the [injectStyles](https://swiperjs.com/element#injecting-styles) from Swiper if it is needed to overwrite or add new styles to inside of Swiper Element Shadow Dom.
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ Then we need to convert each `atom-carousel-item` into `swiper-slide`.
## Considered Options
To convert the inner `<atom-carousel-item>` to `<swiper-slide>`, and we have two options:

- Create and `atom-carousel-item` component and inside itself creating the `<swiper-slide>` component on parent and them self deleting from parent.
- The parent itself convert all children at once.
1. Create and `atom-carousel-item` component and inside itself creating the `<swiper-slide>` component on parent and them self deleting from parent.
2. The parent itself convert all children at once.

## Decision Drivers

Expand Down

0 comments on commit 0287647

Please sign in to comment.