Skip to content

Commit

Permalink
Merge branch 'main' into release-please--branches--main
Browse files Browse the repository at this point in the history
  • Loading branch information
felipefialho authored Nov 6, 2024
2 parents a154115 + c5de2cb commit 361f9b1
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 9 deletions.
6 changes: 3 additions & 3 deletions packages/core/src/components/select/select.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import {
Element,
Event,
EventEmitter,
Host,
Prop,
h,
Host,
Method,
Prop,
} from '@stencil/core'

import { IconProps } from '../../icons'
Expand Down Expand Up @@ -50,7 +50,7 @@ export class AtomSelect {
@Event() atomFocus!: EventEmitter<void>

@Method()
setTagInSelectOptions() {
async setTagInSelectOptions() {
/**
* This method was necessary because the `ion-selection-option` loop does not allow customizations or custom components.
* So, to be able to add custom elements such as a tag or a badge inside an option of the `select` field, when the select
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,18 @@ export const Multiple: StoryObj = {
}

const optionWithTag = [
...optionsDefault,
{
id: '3',
id: '1',
value: 'Nice Green',
disabled: false,
tag: { color: 'success', label: 'New ' },
},
{
id: '2',
value: 'Nice Red',
disabled: false,
tag: { color: 'danger', label: 'Old ' },
},
]

export const WithTag: StoryObj = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,18 @@ export const Multiple: StoryObj = {
}

const optionWithTag = [
...optionsDefault,
{
id: '3',
id: '1',
value: 'Nice Green',
disabled: false,
tag: { color: 'success', label: 'New ' },
},
{
id: '2',
value: 'Nice Red',
disabled: false,
tag: { color: 'danger', label: 'Old ' },
},
]

export const WithTag: StoryObj = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,14 +93,20 @@ export const Multiple: StoryObj = {
multiple: true,
},
}

const optionWithTag = [
...optionsDefault,
{
id: '3',
id: '1',
value: 'Nice Green',
disabled: false,
tag: { color: 'success', label: 'New ' },
},
{
id: '2',
value: 'Nice Red',
disabled: false,
tag: { color: 'danger', label: 'Old ' },
},
]

export const WithTag: StoryObj = {
Expand Down

0 comments on commit 361f9b1

Please sign in to comment.