Skip to content

Commit

Permalink
fix(modal): change variable's name on modal to zindex (#617)
Browse files Browse the repository at this point in the history
  • Loading branch information
jowjow22 authored Nov 11, 2024
1 parent f35dfe5 commit 7d02f87
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/core/src/components/modal/modal.scss
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@import '~@atomium/scss-utils/index';

:host {
--atom-modal-z-index: var(--zindex-1000);
--atom-modal-zindex: var(--zindex-1000);
}

.atom-modal {
position: fixed;
z-index: var(--atom-modal-z-index) !important;
z-index: var(--atom-modal-zindex) !important;

&__close {
position: absolute;
Expand Down
8 changes: 8 additions & 0 deletions packages/core/src/components/modal/stories/modal.args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,14 @@ export const ModalStoryArgs = {
category: Category.SLOTS,
},
},
'--atom-modal-zindex': {
description:
'The z-index of the modal, to change this value using CSS custom properties, change its value on root element. This needs to be done this way because the ion-modal is rendered on the body element.',
defaultValue: { summary: '--zindex-1000' },
table: {
category: Category.CSS_CUSTOM_PROPERTIES,
},
},
},
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,14 @@ export const ModalStoryArgs = {
category: Category.SLOTS,
},
},
'--atom-modal-zindex': {
description:
'The z-index of the modal, to change this value using CSS custom properties, change its value on root element. This needs to be done this way because the ion-modal is rendered on the body element.',
defaultValue: { summary: '--zindex-1000' },
table: {
category: Category.CSS_CUSTOM_PROPERTIES,
},
},
},
}

Expand Down

0 comments on commit 7d02f87

Please sign in to comment.