Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button-form-functions #230

Merged
merged 7 commits into from
Aug 4, 2023
Merged

fix: button-form-functions #230

merged 7 commits into from
Aug 4, 2023

Conversation

LucasGomestl
Copy link
Contributor

@LucasGomestl LucasGomestl commented Aug 3, 2023

Infos

Task

What is being delivered?

fix the button behavior when type is submit or reset

What impacts?

it only impacts the AtomButton behavior

Reversal plan

revert the commit

Evidences

Before
Screen Recording 2023-08-04 at 11 25 57

After
Screen Recording 2023-08-04 at 11 22 30

@LucasGomestl LucasGomestl added the bug Something isn't working label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-08-04 18:39 UTC

@LucasGomestl LucasGomestl changed the title [WIP]fix: button-form-functions fix: button-form-functions Aug 4, 2023
@LucasGomestl LucasGomestl marked this pull request as ready for review August 4, 2023 15:46
@LucasGomestl LucasGomestl requested review from a team, giuliatondin, IngridCavalcantiGti, jowjow22 and deverebor and removed request for a team August 4, 2023 15:47
Copy link
Contributor

@RodrigoRVSN RodrigoRVSN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

[juntossomosmais_atomium_core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@LucasGomestl LucasGomestl merged commit 5ebf791 into main Aug 4, 2023
4 checks passed
@LucasGomestl LucasGomestl deleted the fix/button-form-functions branch August 4, 2023 18:34
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
felipefialho pushed a commit that referenced this pull request Aug 4, 2023
@github-actions github-actions bot mentioned this pull request Oct 17, 2023
This was referenced Feb 15, 2024
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
@github-actions github-actions bot mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants