-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: button-form-functions #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LucasGomestl
changed the title
[WIP]fix: button-form-functions
fix: button-form-functions
Aug 4, 2023
LucasGomestl
requested review from
a team,
giuliatondin,
IngridCavalcantiGti,
jowjow22 and
deverebor
and removed request for
a team
August 4, 2023 15:47
schirrel
approved these changes
Aug 4, 2023
RodrigoRVSN
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…tton-form-functions
…tton-form-functions
[juntossomosmais_atomium_core] Kudos, SonarCloud Quality Gate passed! |
Merged
felipefialho
pushed a commit
that referenced
this pull request
Aug 4, 2023
Co-authored-by: Alan Schio <[email protected]>
Closed
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
fix the button behavior when type is submit or reset
What impacts?
it only impacts the AtomButton behavior
Reversal plan
revert the commit
Evidences
Before
After