fix: use line-height in badge #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielduete
requested review from
bomffas,
IngridCavalcantiGti,
jowjow22 and
deverebor
and removed request for
a team
|
[juntossomosmais_atomium_core] Kudos, SonarCloud Quality Gate passed! |
|
LucasGomestl
approved these changes
Aug 25, 2023
schirrel
approved these changes
Aug 25, 2023
RodrigoRVSN
approved these changes
Aug 28, 2023
luiz-ortega
approved these changes
Aug 28, 2023
Merged
Closed
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
Adding propriety
line-height: 0inHostofbadgecomponent, because the component needs to conform to the context of the container it's embedded in.What impacts?
Component badge
Reversal plan
Reset commit to the previous version.
Evidences
Before
After
