fix(modal): set new z index value for modal and steps modal #615
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jowjow22
changed the title
jowjow22
requested review from
igorwessel,
felipefialho and
matheus-rosa-jsm
and removed request for
igorwessel and
felipefialho
igorwessel
approved these changes
Nov 11, 2024
tassioFront
approved these changes
Nov 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
Setting the new value for z-index on atom modal, the motivation is that ionic sets it too high and most of other UI libraries doesn't use this value (the value for it before was 20002)
What impacts?
Atom modal component styling and Atom steps modal component
Reversal plan
Re release of the previous version and revert on main branch
Evidences
Media(images, gifs or videos) that shows the result of your work.