-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): included wrappers and tests for opentelemetry instrumentation #4
feat(core): included wrappers and tests for opentelemetry instrumentation #4
Conversation
@@ -0,0 +1,12 @@ | |||
[tox] | |||
skipsdist=True | |||
envlist = py310 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: We should include the Python versions that are used by ours ecosystem. If we use 3.7 until 3.10, then this would be:
envlist = py310 | |
envlist = py37,py38,py39,py310 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great suggestion, initially we use only python version because tests with tox running inner docker container have a only python3.10 version. I'm created this issue to implement this feature.
opentelemetry_instrumentation_django_stomp/instrumentors/consumer_instrument.py
Outdated
Show resolved
Hide resolved
opentelemetry_instrumentation_django_stomp/instrumentors/publisher_instrument.py
Outdated
Show resolved
Hide resolved
@@ -0,0 +1 @@ | |||
__version__ = "0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change the version, we should update it here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. The idea is update to the correct version of PR from release/first-version to main branch.
Infos
Create
DjangoStompInstrumentor
to create wrapper from django-stomp code and instrument publisher, consumer, ack and nack traces. more details in README.mdDjangoStompInstrumentor
django-stomp
instrumentators;DjangoStompInstrumentor.instrument()
executeConsumerInstrument.instrument()
andPublisherInstrument.instrument()
;ConsumerInstrument
PublisherInstrument
📁 Folder Structure with tests