Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holoviews support: fix output path fetching #544

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

stevejpurves
Copy link
Contributor

@stevejpurves stevejpurves commented Feb 28, 2025

This fixes a bug in how outputs with multiple minified mime bundles (with path properties) were having their mime bundles properly fetched and rebuilt, resulting in some mimebundles being stripped.

This had a direct effect on holoviews (bokeh, plotly) which this PR fixes (related: #527)

This bug could have also been responsible for other unexpected behaviour where ever the multiple minified mimebundles are present.

Copy link

changeset-bot bot commented Feb 28, 2025

🦋 Changeset detected

Latest commit: 6c9624e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@myst-theme/jupyter Patch
@myst-theme/providers Patch
@myst-theme/frontmatter Patch
@myst-theme/diagrams Patch
@myst-theme/site Patch
@myst-theme/styles Patch
@myst-theme/common Patch
@myst-theme/icons Patch
@myst-theme/search Patch
@myst-theme/search-minisearch Patch
@myst-theme/book Patch
@myst-theme/article Patch
myst-to-react Patch
myst-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@stevejpurves
Copy link
Contributor Author

looks good for holoviews, needs a bunch of checking against other content for regressions.

@agoose77
Copy link
Collaborator

agoose77 commented Mar 4, 2025

@stevejpurves just seen the review request -- Will take a look tomorrow, but not worried if someone else reviews and merges first.

Copy link
Collaborator

@agoose77 agoose77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, the fix here is that previously we were evaluating

(...links) => links.forEach(fn(link[0]));

which ultimately only handled links[0]. Now we're evaluating

(links) => links.forEach(fn(link));

LGTM!

@stevejpurves stevejpurves merged commit 5af4e8d into main Mar 5, 2025
2 checks passed
@stevejpurves stevejpurves deleted the fix/hv-output-fetching branch March 5, 2025 13:10
This was referenced Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants