Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Clean up links to EB & unify READMEs for packages #550

Merged
merged 3 commits into from
Mar 5, 2025
Merged

🧹 Clean up links to EB & unify READMEs for packages #550

merged 3 commits into from
Mar 5, 2025

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Mar 5, 2025

This PR does some general cleanup to remove EB references where we now use JB, and to ensure that the links and badges are all up to date.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2a45098

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agoose77 agoose77 requested a review from stevejpurves March 5, 2025 11:25
@agoose77
Copy link
Collaborator Author

agoose77 commented Mar 5, 2025

I'm not adding a changeset because this only changes some published metadata in site/package.json and themes/article/template.yml that's not super urgent to ship.

@agoose77
Copy link
Collaborator Author

agoose77 commented Mar 5, 2025

Biasing to action and merging!

@agoose77 agoose77 merged commit 764a3b6 into main Mar 5, 2025
2 checks passed
@agoose77 agoose77 deleted the agoose77/chore-update-readmes branch March 5, 2025 11:48
rowanc1
rowanc1 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/myst-demo/README.md
@@ -1,7 +1,7 @@
# myst-demo

[![myst-demo on npm](https://img.shields.io/npm/v/myst-demo.svg)](https://www.npmjs.com/package/myst-demo)
[![MIT License](https://img.shields.io/badge/license-MIT-blue.svg)](https://github.com/curvenote/curvenote/blob/main/LICENSE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like three moves out of date!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, we got there eventually! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanc1 rowanc1 rowanc1 approved these changes

@stevejpurves stevejpurves Awaiting requested review from stevejpurves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @rowanc1