Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♹ Small types improvements #559

Merged
merged 1 commit into from
Mar 6, 2025
Merged

♹ Small types improvements #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions packages/myst-demo/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@
import { remove } from 'unist-util-remove';
import type { VFileMessage } from 'vfile-message';
import { load as yamlLoad, dump as yamlDump } from 'js-yaml';
import {
fileError,
RuleId,
type GenericNode,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't used in this file.

type GenericParent,
type References,
} from 'myst-common';
import { fileError, RuleId, type GenericParent, type References } from 'myst-common';
import type { Code } from 'myst-spec';
import { SourceFileKind } from 'myst-spec-ext';
import type { DocxResult } from 'myst-to-docx';
Expand Down Expand Up @@ -148,9 +142,8 @@
const mdastPre = JSON.parse(JSON.stringify(mdast));
visit(mdastPre, (n) => delete n.position);
const htmlString = mystToHtml(JSON.parse(JSON.stringify(mdast)));
const references = {
const references: References = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only actual addition.

cite: { order: [], data: {} },
footnotes: {},
};
const frontmatterRaw = getFrontmatter(vfile, mdast);
const frontmatter: Omit<PageFrontmatter, 'parts'> = validatePageFrontmatter(frontmatterRaw, {
Expand Down Expand Up @@ -392,7 +385,7 @@
);

const mdastStage = astStage === 'pre' ? mdastPre : mdastPost;
const { downloads, exports, parts, ...reducedFrontmatter } = frontmatter;

Check warning on line 388 in packages/myst-demo/src/index.tsx

View workflow job for this annotation

GitHub Actions / lint 

'downloads' is assigned a value but never used

Check warning on line 388 in packages/myst-demo/src/index.tsx

View workflow job for this annotation

GitHub Actions / lint 

'exports' is assigned a value but never used

Check warning on line 388 in packages/myst-demo/src/index.tsx

View workflow job for this annotation

GitHub Actions / lint 

'parts' is assigned a value but never used

return (
<figure
Expand Down
Loading