Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs update tofor canvas.stroke(path2D) in drawing_paths.rst #356

Closed
wants to merge 12 commits into from
Closed

docs update tofor canvas.stroke(path2D) in drawing_paths.rst #356

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ca688f6
Add stroke path to Path2D interface per html canvas spec (#1)
cleemesser Sep 3, 2024
50c05a0
add visual test of canvas.stroke(path)
Sep 5, 2024
c441fa7
Update Playwright Snapshots
github-actions[bot] Sep 5, 2024
20b1fc3
Merge branch 'jupyter-widgets-contrib:master' into master
cleemesser Sep 5, 2024
e7c8937
black ipycanvas/canvas.py
Sep 5, 2024
d10f638
fix bug falling through to fillPath-add missing break
Sep 5, 2024
aa16f26
initial documentation stroke(Path2D)
Sep 5, 2024
e1985dc
update initial stroke(path) uitest to replicate SVG fig
Sep 5, 2024
b6ef638
black format code block in drawing_paths.rst
Sep 6, 2024
bc62c67
Update Playwright Snapshots
github-actions[bot] Sep 6, 2024
137c6e1
Merge branch 'jupyter-widgets-contrib:master' into master
cleemesser Sep 6, 2024
58b4973
drawing paths suggested doc edit
Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/drawing_paths.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ There are two ways for creating and drawing a path in ipycanvas.
Using Path2D
------------

You can define a Path2D given an SVG path. Note that once the path is created, it is read only, you cannot dynamically change the path value. This means they do not (yet) support Path2D methods like Path2D.move_to, draw_line, etc.
You can define a Path2D given an SVG path. Note that once the path is created, it is read only, you cannot dynamically change the path value. ``ipycanvas`` does not (yet) support Path2D methods like Path2D.move_to, draw_line, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this based off my review from your other PR? I actually prefer the original version you came up with, I changed my mind

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I read that discussion and made the change. If you changed your mind, you can close this PR, and I will fix my fork.
Thanks for the git help.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing! Thanks for your PRs!

Using the Path2D class is very useful and efficient when you want to reuse the same path multiple times. Path2D objects may be stroked or filled.

See https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Paths for documentation about SVG paths.
Expand Down
Loading