Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong tag index in TagsInput when updated via python #3862

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

s-weigand
Copy link
Contributor

This change fixes a bug in the TagsInput when the value attribute is updated from python with a list of different length than the widget currently has and the inputIndex in the frontend not being updated.

This leads to wrong insertions of new values
TagsInput-bug

Copy link

Binder 👈 Launch a binder notebook on branch s-weigand/ipywidgets/fix-tag-input

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 5ce66fc into jupyter-widgets:main Aug 22, 2024
1 check passed
@s-weigand s-weigand deleted the fix-tag-input branch August 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants