Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #606

Merged
merged 17 commits into from
Mar 12, 2024
Merged

Update CI #606

merged 17 commits into from
Mar 12, 2024

Conversation

IsabelParedes
Copy link
Member

No description provided.

@martinRenou
Copy link
Member

@IsabelParedes did you mean to close this?

If you need another pair of eyes on this I could look into it.

@IsabelParedes
Copy link
Member Author

Thanks @martinRenou !
I wasn't able to figure out why the tests on windows were failing just by looking at the CI logs.
But if you have some time to take a look that'd be great :)

@IsabelParedes
Copy link
Member Author

Error with pluggy v1.4.0

- pluggy._manager.PluginValidationError: Plugin 'nbval' for hook 'pytest_collect_file'
- hookimpl definition: pytest_collect_file(path, parent)
- Argument(s) {'path'} are declared in the hookimpl but can not be found in the hookspec

@IsabelParedes
Copy link
Member Author

The environment just needed to be reactivated for the tests on windows to not time out.

@IsabelParedes IsabelParedes marked this pull request as ready for review March 4, 2024 11:48
@JohanMabille JohanMabille merged commit dc8f542 into jupyter-xeus:main Mar 12, 2024
13 checks passed
@JohanMabille
Copy link
Member

Thanks, and sorry for the delay!

@IsabelParedes IsabelParedes deleted the workflow branch March 13, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants