Clarify container.remove() behaviour

jupyter · Feb 22, 2025 · 5f57cb6 · 5f57cb6
1 parent 1bbab5c
commit 5f57cb6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/tagging/utils/docker_runner.py b/tagging/utils/docker_runner.py
@@ -39,9 +39,8 @@ def __exit__(
     ) -> None:
         assert self.container is not None
         LOGGER.info(f"Removing container {self.container.name} ...")
-        if self.container:
-            self.container.remove(force=True)
-            LOGGER.info(f"Container {self.container.name} removed")
+        self.container.remove(force=True)
+        LOGGER.info(f"Container {self.container.name} removed")
 
     @staticmethod
     def run_simple_command(

diff --git a/tests/utils/tracked_container.py b/tests/utils/tracked_container.py
@@ -92,5 +92,9 @@ def _lines_starting_with(logs: str, pattern: str) -> list[str]:
 
     def remove(self) -> None:
         """Kills and removes the tracked docker container."""
-        if self.container:
+        if self.container is None:
+            LOGGER.info("No container to remove")
+        else:
+            LOGGER.info(f"Removing container {self.container.name} ...")
             self.container.remove(force=True)
+            LOGGER.info(f"Container {self.container.name} removed")