Improve JS Test Docs for macOS and Fix Flaky Test (#320)

* Add note for Rosetta needed * Fix img is not defined
jupyter · Feb 13, 2025 · 21d390e · 21d390e
1 parent 25a8c56
commit 21d390e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
@@ -195,6 +195,10 @@ or to run just ``nbclassic/tests/notebook/deletecell.js``::
 
     python -m nbclassic.jstest notebook/deletecell.js
 
+.. note::
+   If you are getting spawn errors with an ARM Mac on macOS, make sure you
+   have Rosetta installed.
+
 
 Building the Documentation
 --------------------------

diff --git a/nbclassic/tests/notebook/attachments.js b/nbclassic/tests/notebook/attachments.js
@@ -42,6 +42,15 @@ casper.notebook_test(function () {
 
     // Validate and render the markdown cell
     this.thenClick('#btn_ok');
+
+    // Wait for cell content to update before rendering
+    this.waitFor(function() {
+        return this.evaluate(function() {
+            var cell = Jupyter.notebook.get_cell(0);
+            return cell.get_text().indexOf('![') >= 0;
+        });
+    });
+
     this.thenEvaluate(function() {
         Jupyter.notebook.get_cell(0).render();
     });