Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spawner.db dependency to address access deprecation #317

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove Spawner.db dependency to address access deprecation #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ed2e1d
Remove test orm depenedency and drop event_loop
tgmachina Dec 1, 2024
e7b7a5a
Drop db commit in start
tgmachina Dec 1, 2024
d76422e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion batchspawner/batchspawner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,6 @@ async def start(self):
" but died before launching the single-user server."
)

self.db.commit()
self.log.info(
"Notebook server job {} started at {}:{}".format(
self.job_id, self.ip, self.port
Expand Down
3 changes: 0 additions & 3 deletions batchspawner/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
"""Relevant pytest fixtures are re-used from JupyterHub's test suite"""

# We use "db" directly, but we also need event_loop
from jupyterhub.tests.conftest import db, event_loop # noqa
Loading