Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all list based config to be assigned dictionaries #845

Merged

Conversation

sunu
Copy link
Contributor

@sunu sunu commented Jul 26, 2024

As a continuation of #843, allow more pod properties to be defined as dictionaries for easy overriding.

Adds dictionary support for init_containers, extra_containers, tolerations, node_affinity_preferred, node_affinity_required, pod_affinity_preferred, pod_affinity_required, pod_anti_affinity_preferred and pod_anti_affinity_required

@sunu sunu marked this pull request as ready for review July 28, 2024 15:18
@yuvipanda yuvipanda merged commit 4263474 into jupyterhub:main Jul 29, 2024
9 checks passed
@yuvipanda
Copy link
Collaborator

Thank you very much for adding the detailed tests, @sunu!

@consideRatio consideRatio changed the title Allow more pod properties to be defined as dictionaries Allow all list based config to be assigned dictionaries Sep 22, 2024
@consideRatio
Copy link
Member

Nice coverage!!

With the trivial exception of storage_access_modes, which is just a list of strings where assignment as dicts probably isn't helpful, this PR covered all list based config! I updated the PR title to capture this a bit better now that I'm to generate a changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants